Add wrapping and tests for PhasedArray3DSpecialCoordinatesImage#232
Add wrapping and tests for PhasedArray3DSpecialCoordinatesImage#232dzenanz merged 5 commits intoKitwareMedical:masterfrom
Conversation
Warnings of style: C:\Dev\ITKUltrasound-22\Wrapping\Modules\Ultrasound\itkPhasedArray3DSpecialCoordinatesImagePython.cpp(5263,54): warning C4834: discarding return value of function with 'nodiscard' attribute
tbirdso
left a comment
tbirdso
left a comment
There was a problem hiding this comment.
Code looks good to me. @dzenanz can you confirm that Python tests pass locally on your system?
It looks like itk::PhaseArray3DSpecialCoordinatesImage is implemented in ITK/Core/Common, could you comment on the decision to add wrapping here in ITKUltrasound? Maybe the wrapping for itk::PhaseArray3DSpecialCoordinatesImage and general filters could be moved there and then the wrapping for ITKUltrasound spectral analysis filters could be kept here? Though I am not sure whether it is worth the effort or not.
|
All the tests pass locally, including the ones this PR adds. I also though about adding wrapping to ITK/Core/Common, but:
Moving the wrapping to ITK core should be easy - just move the |
|
@dzenanz Sounds reasonable to me, thanks for commenting. Good to move forward with changes as-is. |
|
+1 for migrating this to ITK |
|
Migrating to ITK via InsightSoftwareConsortium/ITK#4101. |
3 participants
No description provided.